Re: [PATCH v2] genirq: Check irq disabled & masked states in irq_shutdown

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] genirq: Check irq disabled & masked states in irq_shutdown
Date	2017-05-27 13:00 +0200
Message-ID	<tLHBT-2aL-3@gated-at.bofh.it> (permalink)
References	<tLBZw-70X-3@gated-at.bofh.it> <tLFqp-Nl-5@gated-at.bofh.it> <tLGPv-1Om-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 27 May 2017, jeffy wrote:
> On 05/27/2017 04:30 PM, Thomas Gleixner wrote:
> > On Sat, 27 May 2017, Jeffy Chen wrote:
> > 
> > > If a irq is already disabled & masked, free_irq may cause a unbalanced
> > > irq shutdown/disable/mask, for example:
> > 
> > No, it's not. irq_shutdown/disable/mask are low level access functions
> > which can be invoked at any given time.
> > 
> > The only interface which has refcounting is disable/enable_irq().
> but i think it still be good trying to make them balance, at least for irq
> enable/disable :)

If we make them balanced then we do it proper and not just for the single
issue you are facing. And we do not try. We analyze it proper and fix it.

It's not rocket science, but yes it takes a bit longer than cobbling
something together which works just for you.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] genirq: Check irq disabled & masked states in irq_shutdown Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-05-27 07:00 +0200
  Re: [PATCH v2] genirq: Check irq disabled & masked states in  irq_shutdown Thomas Gleixner <tglx@linutronix.de> - 2017-05-27 10:40 +0200
    Re: [PATCH v2] genirq: Check irq disabled & masked states in irq_shutdown jeffy <jeffy.chen@rock-chips.com> - 2017-05-27 12:10 +0200
      Re: [PATCH v2] genirq: Check irq disabled & masked states in  irq_shutdown Thomas Gleixner <tglx@linutronix.de> - 2017-05-27 13:00 +0200

csiph-web