Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650776
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets |
| Date | 2017-05-25 21:50 +0200 |
| Message-ID | <tL6VI-3XA-9@gated-at.bofh.it> (permalink) |
| References | <tK9LY-6FW-7@gated-at.bofh.it> <tL3Et-1ZE-11@gated-at.bofh.it> <tL6VI-3XA-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Peter Dawson <petedaws@gmail.com>
Date: Fri, 26 May 2017 05:46:27 +1000
> On Thu, 25 May 2017 12:11:17 -0400 (EDT)
> David Miller <davem@davemloft.net> wrote:
>
>> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661
>>
>> This is not the correct way to use the Fixes: tag.
>>
>> You should specify the commit that introduced the regression
>> between 4.9.x and 4.10.x, and that you are fixing here.
>
> Thanks for your review Dave. I'll resubmit the patch with the following detail and just reference the bugzilla in the main body of the commit comment.
>
> Commit 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0") caused the regression by masking out the flowlabel which exposed the incorrect the handling of the DSCP portion of the flowlabel in ip6_tunnel and ip6_gre.
Still not correct, you need to use a "Fixes: " tag of the form:
Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0")
And it must appear of the first line of tags, before signoffs and acks,
with no empty lines in between.
Thank you.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets David Miller <davem@davemloft.net> - 2017-05-25 18:20 +0200
Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets Peter Dawson <petedaws@gmail.com> - 2017-05-25 21:50 +0200
Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets David Miller <davem@davemloft.net> - 2017-05-25 21:50 +0200
Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets Peter Dawson <petedaws@gmail.com> - 2017-05-25 22:10 +0200
Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets David Miller <davem@davemloft.net> - 2017-05-25 22:40 +0200
csiph-web