Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1650683

Re: [PATCH] RFC: arm: eBPF JIT compiler

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH] RFC: arm: eBPF JIT compiler
Date 2017-05-25 19:30 +0200
Message-ID <tL4Ke-2DT-15@gated-at.bofh.it> (permalink)
References (1 earlier) <tKoUG-8uq-25@gated-at.bofh.it> <tKp4m-7w-19@gated-at.bofh.it> <tKrpv-1YV-1@gated-at.bofh.it> <tKLey-72S-13@gated-at.bofh.it> <tL4qT-2vP-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, May 25, 2017 at 07:00:51PM +0200, Andrew Lunn wrote:
> On Thu, May 25, 2017 at 02:01:36AM +0530, Shubham Bansal wrote:
> > Hi Andrew,
> > 
> > I am attaching the latest patch which should work on ARMv5 , ARMv6 and ARMv7.
> > 
> > Please test on your machines. Apologies for the last patch. This patch
> > should work though.
> 
> andrew@shuttle:~/linux$ make -s -j 16
> arch/arm/net/bpf_jit_32.c:1755:12: warning: ‘validate_code’ defined but not used [-Wunused-function]
>  static int validate_code(struct jit_ctx *ctx)
>             ^~~~~~~~~~~~~
> arch/arm/net/bpf_jit_32.c:1724:12: warning: ‘build_body’ defined but not used [-Wunused-function]
>  static int build_body(struct jit_ctx *ctx)
>             ^~~~~~~~~~
> arch/arm/net/bpf_jit_32.c:1122:13: warning: ‘build_epilogue’ defined but not used [-Wunused-function]
>  static void build_epilogue(struct jit_ctx *ctx)
>              ^~~~~~~~~~~~~~
> arch/arm/net/bpf_jit_32.c:1049:13: warning: ‘build_prologue’ defined but not used [-Wunused-function]
>  static void build_prologue(struct jit_ctx *ctx)
>              ^~~~~~~~~~~~~~
> arch/arm/net/bpf_jit_32.c:174:13: warning: ‘jit_fill_hole’ defined but not used [-Wunused-function]
>  static void jit_fill_hole(void *area, unsigned int size)
>              ^~~~~~~~~~~~~
> 
> I _think_ this is because CONFIG_CPU_LITTLE_ENDIAN is not set. But it
> is a little endian machine/configuration. ARM does not seem to use
> CONFIG_CPU_LITTLE_ENDIAN, it just has CPU_BIG_ENDIAN.

After removing the #ifdef:

test_bpf: Summary: 314 PASSED, 0 FAILED, [272/306 JIT'ed]

Each test prints:

ARM version : 5
ARM version : 5

So the code needs some cleanup, but seems to basically work.

   Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] RFC: arm: eBPF JIT compiler Andrew Lunn <andrew@lunn.ch> - 2017-05-25 19:10 +0200
  Re: [PATCH] RFC: arm: eBPF JIT compiler Andrew Lunn <andrew@lunn.ch> - 2017-05-25 19:30 +0200
    Re: [PATCH] RFC: arm: eBPF JIT compiler Andrew Lunn <andrew@lunn.ch> - 2017-05-25 20:30 +0200
      Re: [PATCH] RFC: arm: eBPF JIT compiler Shubham Bansal <illusionist.neo@gmail.com> - 2017-05-25 20:40 +0200
        Re: [PATCH] RFC: arm: eBPF JIT compiler Andrew Lunn <andrew@lunn.ch> - 2017-05-25 20:50 +0200
          Re: [PATCH] RFC: arm: eBPF JIT compiler Shubham Bansal <illusionist.neo@gmail.com> - 2017-05-25 21:10 +0200
            Re: [PATCH] RFC: arm: eBPF JIT compiler Florian Fainelli <f.fainelli@gmail.com> - 2017-05-25 21:50 +0200
              Re: [PATCH] RFC: arm: eBPF JIT compiler Shubham Bansal <illusionist.neo@gmail.com> - 2017-05-25 22:10 +0200
                Re: [PATCH] RFC: arm: eBPF JIT compiler Kees Cook <keescook@chromium.org> - 2017-05-25 23:00 +0200
                Re: [PATCH] RFC: arm: eBPF JIT compiler Florian Fainelli <f.fainelli@gmail.com> - 2017-05-25 23:20 +0200
              Re: [PATCH] RFC: arm: eBPF JIT compiler Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-26 00:20 +0200

csiph-web