Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1650647

Re: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls
Date 2017-05-25 18:50 +0200
Message-ID <tL47w-29T-19@gated-at.bofh.it> (permalink)
References <tKMaC-7Ek-3@gated-at.bofh.it> <tKMtX-7Lj-21@gated-at.bofh.it> <tKTF7-45C-5@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw


On Thu, May 25, 2017 at 07:29:05AM +0200, Peter Huewe wrote:
> > The memory copy from rodata to stack is useless.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> After review, yes that should work.
> Reviewed-by: Peter Huewe <peterhuewe@gmx.de>

Yes, the string gets stored to rodata section where it is copied to
stack :-)

Thanx!

/Jarkko

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Aw: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls "Peter Huewe" <PeterHuewe@gmx.de> - 2017-05-25 07:40 +0200
  Re: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-05-25 18:50 +0200

csiph-web