Re: [PATCH v3] Add "shutdown" to "struct class".

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] Add "shutdown" to "struct class".
Date	2017-05-25 18:50 +0200
Message-ID	<tL47w-29T-15@gated-at.bofh.it> (permalink)
References	<tHs8p-2IK-3@gated-at.bofh.it> <tL0Qi-fG-9@gated-at.bofh.it> <tL3bs-1AL-25@gated-at.bofh.it> <tL3uN-1Wk-3@gated-at.bofh.it> <tL3Oa-237-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 25, 2017 at 09:24:30AM -0700, Josh Zimmerman wrote:
> On Thu, May 25, 2017 at 9:09 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, May 25, 2017 at 08:40:28AM -0700, Josh Zimmerman wrote:
> >> Thanks, Greg.
> >>
> >> Greg, Jarkko: Do either of you you have any objections to me
> >> backporting these changes to 4.4 and 4.9? I'd like to make sure that
> >> at least the couple most recent LTS kernels have this patch.
> >
> > Why?  What bug does this solve?
> If a TPM2 device has power removed without a TPM2_Shutdown being
> issued, it will increment its "dictionary attack" counter. After that
> counter reaches a certain value, the TPM2 device will lock the user
> out. Adding the shutdown callback allows the TPM kernel driver to send
> TPM2_Shutdown to all TPM2 devices.

Is all of that in the tpm patch description?  If so, great, if not,
please add it.

> > If it meets the rules of
> > Documentation/stable_kernel_rules.txt (or whereever that file moved to),
> > that's fine with me.
> Documentation/process/stable-kernel-rules.rst, right? To comply with
> option 1 referred to there (Adding the appropriate "Cc:" to the
> description), should I send a new patch email or just reply to this
> one and quote the relevant part? (I don't believe the document
> specifies.)

You (or who ever applies these patches) needs to add the cc: stable tag
to them.  I suggest resend these, as a patch series, with that in it, so
that it all makes more sense and the tpm maintainer has an easy job of
it.

thanks,

greg k-h

Thread

Re: [PATCH v3] Add "shutdown" to "struct class". Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 15:20 +0200
  Re: [PATCH v3] Add "shutdown" to "struct class". Josh Zimmerman <joshz@google.com> - 2017-05-25 17:50 +0200
    Re: [PATCH v3] Add "shutdown" to "struct class". Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 18:10 +0200
      Re: [PATCH v3] Add "shutdown" to "struct class". Josh Zimmerman <joshz@google.com> - 2017-05-25 18:30 +0200
        Re: [PATCH v3] Add "shutdown" to "struct class". Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 18:50 +0200
          Re: [PATCH v3] Add "shutdown" to "struct class". Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-05-26 00:50 +0200
    Re: [PATCH v3] Add "shutdown" to "struct class". Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-05-25 19:10 +0200
  Re: [PATCH v3] Add "shutdown" to "struct class". Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-05-25 19:10 +0200

csiph-web