Re: [PATCH 8/8] firmware: vpd: fix confusion between memremap and iounmap

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 8/8] firmware: vpd: fix confusion between memremap and iounmap
Date	2017-05-25 15:50 +0200
Message-ID	<tL1jj-pv-7@gated-at.bofh.it> (permalink)
References	<tKs2e-2wM-17@gated-at.bofh.it> <tKs2f-2wM-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 23, 2017 at 05:07:48PM -0700, Dmitry Torokhov wrote:
> We should not be using iounmap to unmap memory mapped with memremap.
> 
> This fixes following warnings generated by sparse in response to
> incorrect type annotations:
> 
>   CHECK   drivers/firmware/google/vpd.c
> drivers/firmware/google/vpd.c:235:20: warning: incorrect type in argument 1 (different address spaces)
> drivers/firmware/google/vpd.c:235:20:    expected void volatile [noderef] <asn:2>*addr
> drivers/firmware/google/vpd.c:235:20:    got char *baseaddr
> drivers/firmware/google/vpd.c:246:28: warning: incorrect type in argument 1 (different address spaces)
> drivers/firmware/google/vpd.c:246:28:    expected void volatile [noderef] <asn:2>*addr
> drivers/firmware/google/vpd.c:246:28:    got char *baseaddr
> drivers/firmware/google/vpd.c:258:14: warning: incorrect type in assignment (different address spaces)
> drivers/firmware/google/vpd.c:258:14:    expected struct vpd_cbmem [noderef] <asn:2>*temp
> drivers/firmware/google/vpd.c:258:14:    got void *
> 
> Fixes: 049a59db34eb ("firmware: Google VPD sysfs driver")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>

This patch doesn't seem to apply to my tree :(

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 8/8] firmware: vpd: fix confusion between memremap and  iounmap Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-25 15:50 +0200

csiph-web