Re: [PATCH v11 7/9] coresight: add support for CPU debug module

From	Leo Yan <leo.yan@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v11 7/9] coresight: add support for CPU debug module
Date	2017-05-24 02:20 +0200
Message-ID	<tKsbT-2AR-7@gated-at.bofh.it> (permalink)
References	<tKiPf-4kM-9@gated-at.bofh.it> <tKiYX-4oq-35@gated-at.bofh.it> <tKlWO-6kH-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mathieu,

On Tue, May 23, 2017 at 11:39:16AM -0600, Mathieu Poirier wrote:

[...]

> > +static bool debug_enable;
> > +module_param_named(enable, debug_enable, bool, 0600);
> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality "
> > +                "(default is 0, which means is disabled by default)");
> 
> Checkpatch complains about a quoted string split across multiple
> lines.  You can probably removes the second one since information
> about the default value is already detailed in patch 03/09.  In this
> case I suggest modifiying the description to:
> 
> "Control to enable coresight CPU debug functionality"

It's shame for checkpatch.pl warning. Although everytime I used script
before sending out patch set, should think a bit more to handle them
better. Have sent new patch set to dismiss them.

Thanks,
Leo Yan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v11 0/9] coresight: enable debug module Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:20 +0200
  [PATCH v11 1/9] coresight: bindings for CPU debug module Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:20 +0200
  [PATCH v11 8/9] arm64: dts: hi6220: register debug module Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:20 +0200
    Re: [PATCH v11 8/9] arm64: dts: hi6220: register debug module Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-05-23 18:40 +0200
  [PATCH v11 3/9] doc: Add coresight_cpu_debug.enable to kernel-parameters.txt Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:20 +0200
  [PATCH v11 5/9] coresight: of_get_coresight_platform_data: Add missing of_node_put Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:30 +0200
  [PATCH v11 4/9] MAINTAINERS: update file entries for Coresight subsystem Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:30 +0200
  [PATCH v11 6/9] coresight: refactor with function of_coresight_get_cpu Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:30 +0200
  [PATCH v11 7/9] coresight: add support for CPU debug module Leo Yan <leo.yan@linaro.org> - 2017-05-23 16:30 +0200
    Re: [PATCH v11 7/9] coresight: add support for CPU debug module Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-05-23 19:40 +0200
      Re: [PATCH v11 7/9] coresight: add support for CPU debug module Leo Yan <leo.yan@linaro.org> - 2017-05-24 02:20 +0200

csiph-web