[PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb()

From	Matthias Kaehlcke <mka@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb()
Date	2017-05-23 23:00 +0200
Message-ID	<tKp4o-7w-55@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The function was added by commit 0a8b83530b6f ("intel_pmc_ipc: Add Intel
Apollo Lake PMC IPC driver") in 2015 and hasn't been used since then.
Removing it fixes the following warning when building with clang:

    drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function
        'ipc_data_readb' [-Werror,-Wunused-function]

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 drivers/platform/x86/intel_pmc_ipc.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
index e4d4dfe3e1d1..aa2fd58b75c4 100644
--- a/drivers/platform/x86/intel_pmc_ipc.c
+++ b/drivers/platform/x86/intel_pmc_ipc.c
@@ -186,11 +186,6 @@ static inline void ipc_data_writel(u32 data, u32 offset)
 	writel(data, ipcdev.ipc_base + IPC_WRITE_BUFFER + offset);
 }
 
-static inline u8 ipc_data_readb(u32 offset)
-{
-	return readb(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
-}
-
 static inline u32 ipc_data_readl(u32 offset)
 {
 	return readl(ipcdev.ipc_base + IPC_READ_BUFFER + offset);
-- 
2.13.0.219.gdb65acc882-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb() Matthias Kaehlcke <mka@chromium.org> - 2017-05-23 23:00 +0200
  Re: [PATCH] platform/x86: intel_pmc_ipc: Delete unused function  ipc_data_readb() Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-05-24 15:50 +0200
    Re: [PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb() Doug Anderson <dianders@chromium.org> - 2017-05-24 17:50 +0200

csiph-web