Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1648377

Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions

Show all headers | View raw

On Tue, May 23, 2017 at 11:36 AM, Kees Cook <keescook@google.com> wrote:
> On Tue, May 23, 2017 at 12:48 AM, Solar Designer <solar@openwall.com> wrote:
>> For modules_autoload_mode=2, we already seem to have the equivalent of
>> modprobe=/bin/true (or does it differ subtly, maybe in return values?),
>> which I already use at startup on a GPU box like this (preloading
>> modules so that the OpenCL backends wouldn't need the autoloading):
>>
>> nvidia-smi
>> nvidia-modprobe -u -c=0
>> #modprobe nvidia_uvm
>> #modprobe fglrx
>>
>> sysctl -w kernel.modprobe=/bin/true
>> sysctl -w kernel.hotplug=/bin/true
>>
>> but it's good to also have this supported more explicitly and more
>> consistently through modules_autoload_mode=2 while we're at it.  So I
>> support having this mode as well.  I just question the need to have it
>> non-resettable.
>
> I agree it's useful to have the explicit =2 state just to avoid
> confusion when more systems start implementing
> CONFIG_STATIC_USERMODEHELPER and kernel.modprobe becomes read-only
> (though the userspace implementation may allow for some way to disable
> it, etc). I just like avoiding the upcall to modprobe at all.

I fully support =2 to mean "no automatic loading at all".  I dislike
making it non-resettable.  If you can write to sysctls, then, most
likely you can either call init_module() directly or the system has
module loading disabled entirely.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 next 0/3] modules: automatic module loading restrictions Djalal Harouni <tixxdz@gmail.com> - 2017-05-22 14:00 +0200
  [PATCH v4 next 3/3] modules:capabilities: add a per-task modules auto-load mode Djalal Harouni <tixxdz@gmail.com> - 2017-05-22 14:00 +0200
    Re: [PATCH v4 next 3/3] modules:capabilities: add a per-task modules  auto-load mode kbuild test robot <lkp@intel.com> - 2017-05-23 16:20 +0200
  [PATCH v4 next 2/3] modules:capabilities: automatic module loading restriction Djalal Harouni <tixxdz@gmail.com> - 2017-05-22 14:10 +0200
    Re: [PATCH v4 next 2/3] modules:capabilities: automatic module  loading restriction Kees Cook <keescook@chromium.org> - 2017-05-23 00:30 +0200
  Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions Solar Designer <solar@openwall.com> - 2017-05-22 14:20 +0200
    Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Djalal Harouni <tixxdz@gmail.com> - 2017-05-22 15:50 +0200
      Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions Solar Designer <solar@openwall.com> - 2017-05-22 18:50 +0200
        Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Djalal Harouni <tixxdz@gmail.com> - 2017-05-22 22:00 +0200
          Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Kees Cook <keescook@chromium.org> - 2017-05-23 01:10 +0200
            Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Andy Lutomirski <luto@kernel.org> - 2017-05-23 01:40 +0200
              Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Kees Cook <keescook@chromium.org> - 2017-05-23 02:00 +0200
              Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Djalal Harouni <tixxdz@gmail.com> - 2017-05-23 15:10 +0200
            Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module loading restrictions Solar Designer <solar@openwall.com> - 2017-05-23 09:50 +0200
              Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Kees Cook <keescook@google.com> - 2017-05-23 20:40 +0200
                Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Andy Lutomirski <luto@kernel.org> - 2017-05-23 22:00 +0200
              Re: [kernel-hardening] [PATCH v4 next 0/3] modules: automatic module  loading restrictions Djalal Harouni <tixxdz@gmail.com> - 2017-05-24 20:10 +0200

csiph-web