Re: [PATCH 5/5] kernfs: add exportfs operations

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] kernfs: add exportfs operations
Date	2017-05-23 21:00 +0200
Message-ID	<tKncd-77q-7@gated-at.bofh.it> (permalink)
References	<tK4sV-3eD-3@gated-at.bofh.it> <tK4sW-3eD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 22, 2017 at 03:53:09PM -0700, Shaohua Li wrote:
> +static struct inode *kernfs_nfs_get_inode(struct super_block *sb,
> +		u64 ino, u32 generation)

Heh, do we have to name this kernfs_nfs_get_inode()?  I think it'd be
nice to give it a different name and add a comment explaining the goal
of the interface.

Also, I think it probably would be better to make this an optional
feature of kernfs.  sysfs has no need to provide something like this
yet.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/5] kernfs: add exportfs operations Shaohua Li <shli@fb.com> - 2017-05-23 01:00 +0200
  Re: [PATCH 5/5] kernfs: add exportfs operations Christoph Hellwig <hch@infradead.org> - 2017-05-23 09:50 +0200
    Re: [PATCH 5/5] kernfs: add exportfs operations Tejun Heo <tj@kernel.org> - 2017-05-23 21:00 +0200
      Re: [PATCH 5/5] kernfs: add exportfs operations Christoph Hellwig <hch@infradead.org> - 2017-05-24 19:40 +0200
        Re: [PATCH 5/5] kernfs: add exportfs operations Tejun Heo <tj@kernel.org> - 2017-05-24 19:50 +0200
          Re: [PATCH 5/5] kernfs: add exportfs operations Christoph Hellwig <hch@infradead.org> - 2017-05-24 19:50 +0200
            Re: [PATCH 5/5] kernfs: add exportfs operations Tejun Heo <tj@kernel.org> - 2017-05-24 19:50 +0200
  Re: [PATCH 5/5] kernfs: add exportfs operations Tejun Heo <tj@kernel.org> - 2017-05-23 21:00 +0200

csiph-web