Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1648307
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] livepatch/rcu: Fix stacking of patches when RCU infrastructure is patched |
| Date | 2017-05-23 20:00 +0200 |
| Message-ID | <tKmg9-6t1-5@gated-at.bofh.it> (permalink) |
| References | <tKkem-58v-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 23, 2017 at 05:47:31PM +0200, Petr Mladek wrote: > diff --git a/kernel/livepatch/patch.c b/kernel/livepatch/patch.c > index f8269036bf0b..08acba30ecec 100644 > --- a/kernel/livepatch/patch.c > +++ b/kernel/livepatch/patch.c > @@ -59,7 +59,11 @@ static void notrace klp_ftrace_handler(unsigned long ip, > > ops = container_of(fops, struct klp_ops, fops); > > - rcu_read_lock(); > + /* > + * A variant of synchronize_sched() is used to allow pathing functions > + * where RCU is not wathing, see klp_synchronize_transition(). > + */ > + preempt_disable_notrace(); s/pathing/patching/ s/wathing/watching/ (and same for the duplicated version of the comment below.) Otherwise the patch looks promising, though I'll need to stare at it for a while... -- Josh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] livepatch/rcu: Fix stacking of patches when RCU infrastructure is patched Petr Mladek <pmladek@suse.com> - 2017-05-23 17:50 +0200 Re: [PATCH] livepatch/rcu: Fix stacking of patches when RCU infrastructure is patched Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-23 20:00 +0200 Re: [PATCH] livepatch/rcu: Fix stacking of patches when RCU infrastructure is patched "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-24 20:50 +0200
csiph-web