Re: [PATCH 4/5] kernfs: don't set dentry->d_fsdata

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] kernfs: don't set dentry->d_fsdata
Date	2017-05-23 20:40 +0200
Message-ID	<tKmSS-6YY-5@gated-at.bofh.it> (permalink)
References	<tK4sV-3eD-3@gated-at.bofh.it> <tK4sV-3eD-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Mon, May 22, 2017 at 03:53:08PM -0700, Shaohua Li wrote:
> +#define kernfs_dentry_node(d)  ((d_inode(d))->i_private)

This would oops on a negative dentry.  We need to test d_inode(d) for
NULL first.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] kernfs: don't set dentry->d_fsdata Shaohua Li <shli@fb.com> - 2017-05-23 01:00 +0200
  Re: [PATCH 4/5] kernfs: don't set dentry->d_fsdata Tejun Heo <tj@kernel.org> - 2017-05-23 20:40 +0200

csiph-web