Re: [PATCH v4 0/2] Tango PCIe controller support

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/2] Tango PCIe controller support
Date	2017-05-23 20:40 +0200
Message-ID	<tKmSS-6YY-23@gated-at.bofh.it> (permalink)
References	<tylpw-1FW-7@gated-at.bofh.it> <tKlDs-6c3-15@gated-at.bofh.it> <tKmpQ-6Mp-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 23, 2017 at 08:07:53PM +0200, Mason wrote:
> On 23/05/2017 19:17, Bjorn Helgaas wrote:
> >
> > On Thu, Apr 20, 2017 at 04:24:39PM +0200, Marc Gonzalez wrote:
> >
> >> This patch was split in two, to ease review of two orthogonal
> >> parts (MSI controller and host bridge). NB: the patch is
> >> just split in two where host bridge support starts.
> > 
> > The split is backwards.  The first patch should add basic host bridge
> > support that is functional, though lacking MSI support.  The second should
> > add the MSI support.
> 
> OK, I'll invert the patches.
> 
> Note: the bridge does not support legacy interrupts.
> Without MSI support, EPs can't interrupt the host.
> Is that still considered functional?

Yes.  The driver can at least claim the host bridge and enumerate PCI
devices.  If you add the MSI support first, that code is completely
dead and can never be called until the second patch is merged.

Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 0/2] Tango PCIe controller support Bjorn Helgaas <helgaas@kernel.org> - 2017-05-23 19:20 +0200
  Re: [PATCH v4 0/2] Tango PCIe controller support Mason <slash.tmp@free.fr> - 2017-05-23 20:10 +0200
    Re: [PATCH v4 0/2] Tango PCIe controller support Bjorn Helgaas <helgaas@kernel.org> - 2017-05-23 20:40 +0200

csiph-web