Re: [PATCH] net: ieee802154: fix potential null pointer dereference

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: ieee802154: fix potential null pointer dereference
Date	2017-05-23 20:30 +0200
Message-ID	<tKmJb-6US-13@gated-at.bofh.it> (permalink)
References	<tKmzv-6Qv-13@gated-at.bofh.it> <tKmzv-6Qv-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Marcel,

Quoting Marcel Holtmann <marcel@holtmann.org>:

> Hi Gustavo,
>
>> Null check at line 918: if (!spi) {, implies spi might be NULL.
>> Function spi_get_drvdata() dereference pointer spi.
>> Move pointer priv assignment after the null check.
>>
>> Addresses-Coverity-ID: 1408888
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> drivers/net/ieee802154/ca8210.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> patch has been applied to bluetooth-next tree.
>

Awesome :)

Thanks
--
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] net: ieee802154: fix potential null pointer dereference Marcel Holtmann <marcel@holtmann.org> - 2017-05-23 20:20 +0200
  Re: [PATCH] net: ieee802154: fix potential null pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-23 20:30 +0200

csiph-web