Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1648247

Re: tipc: Delete error messages for failed memory allocations in three functions

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: tipc: Delete error messages for failed memory allocations in three functions
Date 2017-05-23 18:30 +0200
Message-ID <tKkR4-5Bx-9@gated-at.bofh.it> (permalink)
References <tKhJv-3D6-11@gated-at.bofh.it> <tKiFA-4he-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> tipc_subseq_alloc does a kcalloc (memset to 0),
> half of which is immediately overwritten.
> 
> In other words, don't just blindly remove stuff,
> understand what it does and improve it.

Do you suggest another specific source code transformation pattern here?

Regards,
Markus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] tipc: Delete error messages for failed memory allocations in  three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-23 15:10 +0200
  Re: [PATCH] tipc: Delete error messages for failed memory  allocations in three functions Joe Perches <joe@perches.com> - 2017-05-23 16:10 +0200
    Re: tipc: Delete error messages for failed memory allocations in  three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-23 18:30 +0200
      Re: tipc: Delete error messages for failed memory allocations in  three functions Joe Perches <joe@perches.com> - 2017-05-23 18:40 +0200

csiph-web