Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1648157

Re: [PATCH 1/2] crypto: engine - replace pr_xxx by dev_xxx

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] crypto: engine - replace pr_xxx by dev_xxx
Date 2017-05-23 17:00 +0200
Message-ID <tKjrX-4z9-13@gated-at.bofh.it> (permalink)
References <tKgX8-34J-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 2017-05-23 at 14:09 +0200, Corentin Labbe wrote:
> By adding a struct device *dev to struct engine, we could store the
> device used at register time and so use all dev_xxx functions instead of
> pr_xxx.

trivia:

> diff --git a/include/crypto/engine.h b/include/crypto/engine.h
[]
> @@ -58,6 +58,7 @@ struct crypto_engine {
>  	struct list_head	list;
>  	spinlock_t		queue_lock;
>  	struct crypto_queue	queue;
> +	struct device *dev;

Probably nicer to align to column for consistency

	struct device		*dev;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] crypto: engine - replace pr_xxx by dev_xxx Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-23 14:20 +0200
  [PATCH 2/2] crypto: engine - Permit to enqueue skcipher request Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-23 14:20 +0200
  Re: [PATCH 1/2] crypto: engine - replace pr_xxx by dev_xxx Joe Perches <joe@perches.com> - 2017-05-23 17:00 +0200

csiph-web