Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1648193

Re: [PATCH 4/7] clk: mvebu: cp110: introduce a new binding

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/7] clk: mvebu: cp110: introduce a new binding
Date 2017-05-23 17:30 +0200
Message-ID <tKjV0-51B-23@gated-at.bofh.it> (permalink)
References <tIStP-4fG-23@gated-at.bofh.it> <tIStR-4fG-53@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, May 19, 2017 at 05:55:22PM +0200, Gregory CLEMENT wrote:
> The initial intent when the binding of the cp110 system controller was to
> have one flat node. The idea being that what is currently a clock-only
> driver in drivers would become a MFD driver, exposing the clock, GPIO and
> pinctrl functionality. However, after taking a step back, this would lead
> to a messy binding. Indeed, a single node would be a GPIO controller,
> clock controller, pinmux controller, and more.
> 
> This patch adopts a more classical solution of a top-level syscon node
> with sub-nodes for the individual devices. The main benefit will be to
> have each functional block associated to its own sub-node where we can
> put its own properties.
> 
> The introduction of the Armada 7K/8K is still in the early stage so the
> plan is to remove the old binding. However, we don't want to break the
> device tree compatibility for the few devices already in the field. For
> this we still keep the support of the legacy compatible string with a big
> warning in the kernel about updating the device tree.

Good.

> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt | 18 ++++++++++++++----
>  drivers/clk/mvebu/cp110-system-controller.c                                | 63 ++++++++++++++++++++++++++++++++++++++++++++++++---------------
>  2 files changed, 62 insertions(+), 19 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 4/7] clk: mvebu: cp110: introduce a new binding Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-05-19 18:00 +0200
  Re: [PATCH 4/7] clk: mvebu: cp110: introduce a new binding Rob Herring <robh@kernel.org> - 2017-05-23 17:30 +0200

csiph-web