Re: [PATCH 0/2] perf stat: fix segfault when closing events

From	Ganapatrao Kulkarni <gpkulkarni@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] perf stat: fix segfault when closing events
Date	2017-05-23 17:20 +0200
Message-ID	<tKjLk-4VL-27@gated-at.bofh.it> (permalink)
References	<tBczn-6JZ-3@gated-at.bofh.it> <tKeVj-1HK-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 23, 2017 at 3:34 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> Hi,
>
> Does anyone have any comments on these?
>
> I'm happy to rebase/resend if necessary.
>
> I'd very much like to see this fixed.

arm64 platforms have dependency on this patch set to use latest perf tool.
Earliest merge/review is much appreciated!!

>
> Thanks,
> Mark.
>
> On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote:
>> Hi,
>>
>> These patches fix a segfault seen in some cases when perf stat is exiting.
>>
>> We don't balance opening/closing of events in all cases, and go out-of-bounds
>> when we close events. Full details in the patch 2 commit message.
>>
>> Thanks,
>> Mark.
>>
>> Mark Rutland (2):
>>   perf evsel: add per{cpu,thread} close helpers
>>   perf stat: balance opening/closing of events
>>
>>  tools/perf/builtin-stat.c | 24 +++++++++++++++++++++++-
>>  tools/perf/util/evsel.c   | 26 ++++++++++++++++++++------
>>  tools/perf/util/evsel.h   |  4 ++++
>>  3 files changed, 47 insertions(+), 7 deletions(-)
>>
>> --
>> 1.9.1
>>

thanks
Ganapat

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/2] perf stat: fix segfault when closing events Mark Rutland <mark.rutland@arm.com> - 2017-05-23 12:10 +0200
  Re: [PATCH 0/2] perf stat: fix segfault when closing events Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2017-05-23 17:20 +0200

csiph-web