RE: [PATCH] infiniband: hw: qedr: add null check before pointer dereference

From	"Amrani, Ram" <Ram.Amrani@cavium.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] infiniband: hw: qedr: add null check before pointer dereference
Date	2017-05-23 17:10 +0200
Message-ID	<tKjBD-4S4-9@gated-at.bofh.it> (permalink)
References	<tK0pj-KA-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Add null check before dereferencing pointer sgid_attr.ndev
> inside function rdma_vlan_dev_vlan_id().
> 
> Addresses-Coverity-ID: 1373979
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/infiniband/hw/qedr/qedr_cm.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/qedr_cm.c b/drivers/infiniband/hw/qedr/qedr_cm.c
> index 3d7705c..d86dbe8 100644
> --- a/drivers/infiniband/hw/qedr/qedr_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_cm.c
> @@ -270,11 +270,13 @@ static inline int qedr_gsi_build_header(struct qedr_dev *dev,
>  		return rc;
>  	}
> 
> -	vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
> -	if (vlan_id < VLAN_CFI_MASK)
> -		has_vlan = true;
> -	if (sgid_attr.ndev)
> +	if (sgid_attr.ndev) {
> +		vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
> +		if (vlan_id < VLAN_CFI_MASK)
> +			has_vlan = true;
> +
>  		dev_put(sgid_attr.ndev);
> +	}
> 
>  	if (!memcmp(&sgid, &zgid, sizeof(sgid))) {
>  		DP_ERR(dev, "gsi post send: GID not found GID index %d\n",
> --
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks.

Acked-by: Ram Amrani <Ram.Amrani@cavium.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] infiniband: hw: qedr: add null check before pointer  dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-22 20:40 +0200
  Re: [PATCH] infiniband: hw: qedr: add null check before pointer  dereference Leon Romanovsky <leon@kernel.org> - 2017-05-23 09:20 +0200
    RE: [PATCH] infiniband: hw: qedr: add null check before pointer  dereference "Amrani, Ram" <Ram.Amrani@cavium.com> - 2017-05-23 17:10 +0200
  RE: [PATCH] infiniband: hw: qedr: add null check before pointer  dereference "Amrani, Ram" <Ram.Amrani@cavium.com> - 2017-05-23 17:10 +0200

csiph-web