Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1648062

Re: [PATCH] firmware: request_firmware() should propagate -ERESTARTSYS

Show all headers | View raw

On Tue, May 23, 2017 at 03:16:07PM +0200, Martin Fuzzey wrote:
> When -ERESTARTSYS is returned by wait_* due to a signal this should
> be returned from request_firmware() so that the syscall may be
> restarted if necessary.
> 
> Without this it is not possible to distinguish the case of
> request_firmware() failing due to a timeout with that due to a signal.
> 
> In my particular case request_firmware() was being called from
> a sysfs .store() callback and the writing process was the
> Android init process which received a SIGCHLD causing
> request_firmware() to fail.
> 
> Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
> ---
>  drivers/base/firmware_class.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Nice find, should this go to the stable kernels as well?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] firmware: request_firmware() should propagate  -ERESTARTSYS Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-23 15:40 +0200
  Re: [PATCH] firmware: request_firmware() should propagate  -ERESTARTSYS Martin Fuzzey <mfuzzey@parkeon.com> - 2017-05-23 16:40 +0200
    Re: [PATCH] firmware: request_firmware() should propagate  -ERESTARTSYS "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-23 22:00 +0200
      Re: [PATCH] firmware: request_firmware() should propagate  -ERESTARTSYS "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-24 23:00 +0200
        [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-24 23:50 +0200
          Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback Andy Lutomirski <luto@kernel.org> - 2017-05-25 00:10 +0200

csiph-web