Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1647891

Re: [PATCH 3/7] genirq/affinity: factor out a irq_affinity_set helper

From Christoph Hellwig <hch@lst.de>
Newsgroups linux.kernel
Subject Re: [PATCH 3/7] genirq/affinity: factor out a irq_affinity_set helper
Date 2017-05-23 11:40 +0200
Message-ID <tKesi-1hY-25@gated-at.bofh.it> (permalink)
References <tILVn-84l-11@gated-at.bofh.it> <tILVn-84l-13@gated-at.bofh.it> <tJEoN-3nJ-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, May 21, 2017 at 09:03:06PM +0200, Thomas Gleixner wrote:
> > +{
> > +	struct irq_data *data = irq_desc_get_irq_data(desc);
> > +	struct irq_chip *chip = irq_data_get_irq_chip(data);
> > +	bool ret = false;
> > +
> > +	if (!irqd_can_move_in_process_context(data) && chip->irq_mask)
> 
> Using that inline directly will make this function useless on architectures
> which have GENERIC_PENDING_IRQS not set.
> 
> kernel/irq/manage.c has that wrapped. We need to move those wrappers to the
> internal header file, so that it gets compiled out on other platforms.

Ok, will do.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 3/7] genirq/affinity: factor out a irq_affinity_set helper Christoph Hellwig <hch@lst.de> - 2017-05-19 11:00 +0200
  Re: [PATCH 3/7] genirq/affinity: factor out a irq_affinity_set  helper Thomas Gleixner <tglx@linutronix.de> - 2017-05-21 21:10 +0200
    Re: [PATCH 3/7] genirq/affinity: factor out a irq_affinity_set         helper Christoph Hellwig <hch@lst.de> - 2017-05-23 11:40 +0200

csiph-web