Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver
Date	2017-05-23 11:30 +0200
Message-ID	<tKeiB-1cT-9@gated-at.bofh.it> (permalink)
References	(4 earlier) <tGTkl-5ec-5@gated-at.bofh.it> <tHkaS-67d-13@gated-at.bofh.it> <tIcXE-7g7-19@gated-at.bofh.it> <tIp8t-7LV-9@gated-at.bofh.it> <tJ5AK-5kN-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, May 20, 2017 at 7:54 AM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> On Thu 18 May 01:39 PDT 2017, Varadarajan Narayanan wrote:

>> There are 18 pins. 15 pins are common between LCD and NAND. The QPIC
>> controller arbitrates between LCD and NAND. Of the remaining 4, 2 are for
>> NAND and 2 are for LCD exclusively. We plan to group the qpic pins into 3
>> groups namely, qpic_common, qpic_nand and qpic_lcd. Is that ok?
>>
>
> If you consider that you are defining the available functions for this
> pinmuxer and then define the sets of pins exposing these available
> functions it does make sense to just name it "qpic".
>
> I think that naming them _common, _lcd and _nand is just adding
> confusion when it comes to writing the dts files.
>
> @Linus, do you have a different preference here?

No I pretty much trust the driver maintainer to know this best.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-14 06:30 +0200
  Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Varadarajan Narayanan <varada@codeaurora.org> - 2017-05-15 11:10 +0200
    Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Varadarajan Narayanan <varada@codeaurora.org> - 2017-05-15 13:30 +0200
      Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-17 21:50 +0200
        Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Varadarajan Narayanan <varada@codeaurora.org> - 2017-05-18 10:40 +0200
    Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-17 21:40 +0200
      Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Varadarajan Narayanan <varada@codeaurora.org> - 2017-05-18 10:40 +0200
        Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-20 08:00 +0200
          Re: [PATCH v2 1/5] pinctrl: qcom: Add ipq8074 pinctrl driver Linus Walleij <linus.walleij@linaro.org> - 2017-05-23 11:30 +0200

csiph-web