Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1647813

Re: [PATCH 5/6] ubifs: Implement export_operations

From Richard Weinberger <richard@nod.at>
Newsgroups linux.kernel
Subject Re: [PATCH 5/6] ubifs: Implement export_operations
Date 2017-05-23 10:50 +0200
Message-ID <tKdFU-Jg-23@gated-at.bofh.it> (permalink)
References <tJFEd-46j-3@gated-at.bofh.it> <tJFEe-46j-15@gated-at.bofh.it> <tKdwe-Fm-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Christoph,

Am 23.05.2017 um 10:39 schrieb Christoph Hellwig:
>> +static struct inode *ubifs_nfs_get_inode(struct super_block *sb, uint64_t ino,
>> +					 uint32_t generation)
>> +{
>> +	return ubifs_iget(sb, ino);
>> +}
> 
> You need to maintain and check an inode generation counter for this
> to be safe.

UBIFS has no inode generations, inodes simply can't wrap around.
We "handle" it like JFF2 does, we assumes that the NAND is long dead
before we reach the maximum inode number.

Thanks,
//richard

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 5/6] ubifs: Implement export_operations Richard Weinberger <richard@nod.at> - 2017-05-21 22:30 +0200
  Re: [PATCH 5/6] ubifs: Implement export_operations Christoph Hellwig <hch@infradead.org> - 2017-05-23 10:40 +0200
    Re: [PATCH 5/6] ubifs: Implement export_operations Richard Weinberger <richard@nod.at> - 2017-05-23 10:50 +0200
      Re: [PATCH 5/6] ubifs: Implement export_operations Christoph Hellwig <hch@infradead.org> - 2017-05-23 10:50 +0200
        Re: [PATCH 5/6] ubifs: Implement export_operations Richard Weinberger <richard@nod.at> - 2017-05-23 11:00 +0200

csiph-web