Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647745

Re: [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

Show all headers | View raw

On Mon, May 22, 2017 at 6:09 PM, Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
>> +/*
>> + * DRM_MODE_REFLECT_<axis>
>> + *
>> + * Signals that the contents of a drm plane is reflected in the <axis> axis,
>> + * in the same way as mirroring.
>
> That's not what I was after. We're still missing the information about
> the order in which reflection and rotation happens. Also does "in the
> axis" mean the same thing as "along the axis" and not "across the axis"?
> /me thinks the old text was better

There's already a pretty lengthy kernel-doc in drm_blend.c which is
trying to explain all this. Duplicating all these things here is not
all that awesome imo. Can we perhaps instead reference the text in
drm_blend.c and make sure that is the one true source of truth?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 1/2] drm/blend: Fix comment typ-o Robert Foss <robert.foss@collabora.com> - 2017-05-19 23:00 +0200
  [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI Robert Foss <robert.foss@collabora.com> - 2017-05-19 23:00 +0200
    Re: [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI Daniel Vetter <daniel.vetter@ffwll.ch> - 2017-05-23 09:50 +0200
  Re: [PATCH v4 1/2] drm/blend: Fix comment typ-o Daniel Vetter <daniel@ffwll.ch> - 2017-05-22 09:50 +0200

csiph-web