Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647635

[PATCH v2] ocfs2: fix a static checker warning

Show all headers | View raw

This patch will fix a static code checker warning, which looks 
like below,
fs/ocfs2/inode.c:179 ocfs2_iget()
warn: passing zero to 'ERR_PTR'

this warning was caused by the 
commit d56a8f32e4c6 ("ocfs2: check/fix inode block for online file check").
after apply this patch, the error return value will not be NULL(zero).

Signed-off-by: Gang He <ghe@suse.com>
---
 fs/ocfs2/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 382401d..1a1e007 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -136,7 +136,7 @@ struct inode *ocfs2_ilookup(struct super_block *sb, u64 blkno)
 struct inode *ocfs2_iget(struct ocfs2_super *osb, u64 blkno, unsigned flags,
 			 int sysfile_type)
 {
-	int rc = 0;
+	int rc = -ESTALE;
 	struct inode *inode = NULL;
 	struct super_block *sb = osb->sb;
 	struct ocfs2_find_inode_args args;
-- 
1.8.5.6

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] ocfs2: fix a static checker warning Gang He <ghe@suse.com> - 2017-05-23 07:20 +0200
  Re: [PATCH v2] ocfs2: fix a static checker warning Andrew Morton <akpm@linux-foundation.org> - 2017-05-24 00:40 +0200
    Re: [PATCH v2] ocfs2: fix a static checker warning "Gang He" <ghe@suse.com> - 2017-05-24 04:10 +0200
  Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a static checker warning Eric Ren <zren@suse.com> - 2017-05-24 08:30 +0200

csiph-web