Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650269
| From | Nikita Yushchenko <nikita.yoush@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device |
| Date | 2017-05-25 10:10 +0200 |
| Message-ID | <tKW0i-5FH-9@gated-at.bofh.it> (permalink) |
| References | <tJVpD-6c9-9@gated-at.bofh.it> <tKV4e-56G-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> +&edma1 {
>> + status = "okay";
>> +};
>> +
>> +&dspi2 {
>
> Please keep these labelled nodes sort alphabetically.
Ok
>> + bus-num = <1>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_dspi2>;
>> + status = "okay";
>
> We usually have 'status' line at the bottom of property list.
Ok
>> + spi-num-chipselects = <2>;
>> +
>> + hi8435@1 {
>
> Node name should be something generic, while label can be specific
> model name. The following form might be better.
>
> hi8435: sensor@1
Ok
Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.
Anyway let's delay this a bit, up to the reset polarity description
thing in hi8435 is resolved.
Nikita
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-22 15:20 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Stefan Agner <stefan@agner.ch> - 2017-05-22 18:30 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-22 18:30 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Andrew Lunn <andrew@lunn.ch> - 2017-05-22 20:30 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-23 08:10 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Shawn Guo <shawnguo@kernel.org> - 2017-05-25 09:30 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-25 10:10 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Jonathan Cameron <jic23@kernel.org> - 2017-05-28 17:20 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Shawn Guo <shawnguo@kernel.org> - 2017-05-25 09:10 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-25 10:10 +0200
Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Shawn Guo <shawnguo@kernel.org> - 2017-05-25 10:30 +0200
csiph-web