Re: [PATCH 20/24] thunderbolt: Do not touch the hardware if the NHI is gone on resume

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/24] thunderbolt: Do not touch the hardware if the NHI is gone on resume
Date	2017-05-25 09:20 +0200
Message-ID	<tKVdU-5aj-23@gated-at.bofh.it> (permalink)
References	<tIuKR-3YK-5@gated-at.bofh.it> <tIuUy-44c-19@gated-at.bofh.it> <tKFLQ-3z2-11@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, May 24, 2017 at 04:43:10PM +0200, Lukas Wunner wrote:
> On Thu, May 18, 2017 at 05:39:10PM +0300, Mika Westerberg wrote:
> > @@ -655,6 +659,16 @@ static int nhi_resume_noirq(struct device *dev)
> >  {
> >  	struct pci_dev *pdev = to_pci_dev(dev);
> >  	struct tb *tb = pci_get_drvdata(pdev);
> > +	u32 vid;
> > +
> > +	/*
> > +	 * Check that the device is still there. It may be that the user
> > +	 * unplugged last device which causes the host controller to go
> > +	 * away on PCs.
> > +	 */
> > +	pci_read_config_dword(pdev, PCI_VENDOR_ID, &vid);
> > +	if (vid == ~0)
> > +		tb->nhi->going_away = true;
> 
> if (!pci_device_is_present(pdev))

Sure.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 20/24] thunderbolt: Do not touch the hardware if the NHI is gone on resume Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-18 16:50 +0200
  Re: [PATCH 20/24] thunderbolt: Do not touch the hardware if the NHI  is gone on resume Lukas Wunner <lukas@wunner.de> - 2017-05-24 16:50 +0200
    Re: [PATCH 20/24] thunderbolt: Do not touch the hardware if the NHI  is gone on resume Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-25 09:20 +0200

csiph-web