Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650211
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX |
| Date | 2017-05-25 08:30 +0200 |
| Message-ID | <tKUrw-4D7-3@gated-at.bofh.it> (permalink) |
| References | <tKEPN-2YG-33@gated-at.bofh.it> <tKIA3-5m6-43@gated-at.bofh.it> <tKJZ8-6lc-13@gated-at.bofh.it> <tKMWZ-8aU-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 24 May 2017, Steven Rostedt wrote:
> The trampolines uses the module allocation, and it appears, that needs
> to become rw before freeing again.
Indeed. I realized that when enabling more debug options, which led to a
reliable triple fault.
How intuitive.
> I applied this patch, and it appears to fix the bug for me.
It fixes the bug, but ...
> -static inline void tramp_free(void *tramp)
> +static inline void tramp_free(void *tramp, int size)
> {
> + int npages;
> +
> + npages = PAGE_ALIGN(size) >> PAGE_SHIFT;
For correctness sake this wants
set_memory_nx(...);
as well.
> + set_memory_rw((unsigned long)tramp, npages);
> module_memfree(tramp);
> }
I'll clean that up and post a V2.
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-24 15:50 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-24 16:40 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Steven Rostedt <rostedt@goodmis.org> - 2017-05-24 17:10 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-24 20:20 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-24 21:00 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-24 21:40 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-24 21:20 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Steven Rostedt <rostedt@goodmis.org> - 2017-05-25 00:30 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-25 01:20 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-25 08:30 +0200
[PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-25 11:00 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Steven Rostedt <rostedt@goodmis.org> - 2017-05-25 17:20 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-25 19:50 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Kees Cook <keescook@chromium.org> - 2017-05-25 22:00 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-26 09:10 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-05-26 11:40 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-26 12:00 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Michael Ellerman <mpe@ellerman.id.au> - 2017-05-26 13:50 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-26 11:50 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Steven Rostedt <rostedt@goodmis.org> - 2017-05-26 15:40 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Steven Rostedt <rostedt@goodmis.org> - 2017-05-26 16:00 +0200
Re: [PATCH V2] x86/ftrace: Make sure that ftrace trampolines are not RWX Thomas Gleixner <tglx@linutronix.de> - 2017-05-26 16:00 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-25 11:10 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-25 12:40 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Steven Rostedt <rostedt@goodmis.org> - 2017-05-25 17:20 +0200
Re: [PATCH] x86/ftrace: Make sure that ftrace trampolines are not RWX Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-26 03:40 +0200
csiph-web