Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1650191
| From | Nikita Yushchenko <nikita.yoush@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH/RFC] iio: hi8435: do not enable all events by default |
| Date | 2017-05-25 07:50 +0200 |
| Message-ID | <tKTOO-48Y-25@gated-at.bofh.it> (permalink) |
| References | <tKdcS-x7-5@gated-at.bofh.it> <tKK8O-6oz-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
24.05.2017 22:27, Jonathan Cameron wrote: > On Tue, 23 May 2017 11:08:30 +0300 > Nikita Yushchenko <nikita.yoush@cogentembedded.com> wrote: > >> Having all events enabled by default is misleading. >> Userspace should explicitly enable events they want to receive. >> >> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > I agree in principle, but this is a userspace ABI change. Sadly we > can't do it with out risking breaking userspace code... > > One of those we should have caught in review, but now it's there > we can't actually do anything about it unless we are absolutely > sure no one will notice! I see your point. Still, isn't there subsystem-level default that all events are disabled by default? If such, then current hi8435 state breaks subsystem-level rules, which is a [userspace-visible] bug. I'm not sure how far should we go in bug compatibility. One crazy idea could be - make default selectable via device tree (with default set to all-enabled to keep bug-compatibility). But perhaps that's over-reaction.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH/RFC] iio: hi8435: do not enable all events by default Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-23 10:20 +0200
Re: [PATCH/RFC] iio: hi8435: do not enable all events by default Jonathan Cameron <jic23@kernel.org> - 2017-05-24 21:30 +0200
Re: [PATCH/RFC] iio: hi8435: do not enable all events by default Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-25 07:50 +0200
Re: [PATCH/RFC] iio: hi8435: do not enable all events by default Jonathan Cameron <jic23@kernel.org> - 2017-05-28 17:50 +0200
Re: Fw: [PATCH/RFC] iio: hi8435: do not enable all events by default Chris Healy <cphealy@gmail.com> - 2017-05-28 19:10 +0200
Re: [PATCH/RFC] iio: hi8435: do not enable all events by default Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-05-29 07:50 +0200
Re: [PATCH/RFC] iio: hi8435: do not enable all events by default Jonathan Cameron <jic23@kernel.org> - 2017-06-03 11:10 +0200
csiph-web