Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1650130

[PATCH 02/10] ARC: send ipi to all cpus sharing task mm in case of page fault

Show all headers | View raw

From: Noam Camus <noamca@mellanox.com>

This patch is derived due to performance issue.
The use case is a page fault that resides on more than the local cpu.
Trying to broadcast all CPUs results on performance degradation.
So we try to avoid this by sending only to the relevant CPUs.

Signed-off-by: Noam Camus <noamca@mellanox.com>
---
 arch/arc/include/asm/cacheflush.h |    3 ++-
 arch/arc/mm/cache.c               |   12 ++++++++++--
 arch/arc/mm/tlb.c                 |    2 +-
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/arch/arc/include/asm/cacheflush.h b/arch/arc/include/asm/cacheflush.h
index fc662f4..716dba1 100644
--- a/arch/arc/include/asm/cacheflush.h
+++ b/arch/arc/include/asm/cacheflush.h
@@ -33,7 +33,8 @@
 
 void flush_icache_range(unsigned long kstart, unsigned long kend);
 void __sync_icache_dcache(phys_addr_t paddr, unsigned long vaddr, int len);
-void __inv_icache_page(phys_addr_t paddr, unsigned long vaddr);
+void __inv_icache_page(struct vm_area_struct *vma,
+		       phys_addr_t paddr, unsigned long vaddr);
 void __flush_dcache_page(phys_addr_t paddr, unsigned long vaddr);
 
 #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1
diff --git a/arch/arc/mm/cache.c b/arch/arc/mm/cache.c
index 7d3e79b..e1ea57f 100644
--- a/arch/arc/mm/cache.c
+++ b/arch/arc/mm/cache.c
@@ -934,9 +934,17 @@ void __sync_icache_dcache(phys_addr_t paddr, unsigned long vaddr, int len)
 }
 
 /* wrapper to compile time eliminate alignment checks in flush loop */
-void __inv_icache_page(phys_addr_t paddr, unsigned long vaddr)
+void __inv_icache_page(struct vm_area_struct *vma,
+		       phys_addr_t paddr, unsigned long vaddr)
 {
-	__ic_line_inv_vaddr(paddr, vaddr, PAGE_SIZE);
+	struct ic_inv_args ic_inv = {
+		.paddr	= paddr,
+		.vaddr	= vaddr,
+		.sz	= PAGE_SIZE
+	};
+
+	on_each_cpu_mask(mm_cpumask(vma->vm_mm),
+			 __ic_line_inv_vaddr_helper, &ic_inv, 1);
 }
 
 /*
diff --git a/arch/arc/mm/tlb.c b/arch/arc/mm/tlb.c
index c5e70d8..a095608 100644
--- a/arch/arc/mm/tlb.c
+++ b/arch/arc/mm/tlb.c
@@ -626,7 +626,7 @@ void update_mmu_cache(struct vm_area_struct *vma, unsigned long vaddr_unaligned,
 
 			/* invalidate any existing icache lines (U-mapping) */
 			if (vma->vm_flags & VM_EXEC)
-				__inv_icache_page(paddr, vaddr);
+				__inv_icache_page(vma, paddr, vaddr);
 		}
 	}
 }
-- 
1.7.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] ARC plat-eznps upstream cont. Noam Camus <noamca@mellanox.com> - 2017-05-25 04:40 +0200
  [PATCH 02/10] ARC: send ipi to all cpus sharing task mm in case of page fault Noam Camus <noamca@mellanox.com> - 2017-05-25 04:40 +0200
    Re: [PATCH 02/10] ARC: send ipi to all cpus sharing task mm in case  of page fault Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-25 13:40 +0200
  [PATCH 08/10] ARC: [plat-eznps] spinlock aware for MTM Noam Camus <noamca@mellanox.com> - 2017-05-25 04:40 +0200
  [PATCH 06/10] ARC: [plat-eznps] Fix TLB Errata Noam Camus <noamca@mellanox.com> - 2017-05-25 04:40 +0200
    Re: [PATCH 06/10] ARC: [plat-eznps] Fix TLB Errata Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-25 13:10 +0200
      RE: [PATCH 06/10] ARC: [plat-eznps] Fix TLB Errata Noam Camus <noamca@mellanox.com> - 2017-05-25 13:20 +0200
      Re: [PATCH 06/10] ARC: [plat-eznps] Fix TLB Errata Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-06-01 23:20 +0200
  [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an exception Noam Camus <noamca@mellanox.com> - 2017-05-25 04:40 +0200
    Re: [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an  exception Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-25 13:20 +0200
      RE: [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an  exception Noam Camus <noamca@mellanox.com> - 2017-05-25 13:30 +0200
        Re: [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an  exception Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-25 13:40 +0200
          RE: [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an  exception Noam Camus <noamca@mellanox.com> - 2017-05-25 14:10 +0200
            Re: [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an  exception Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-25 14:10 +0200
          Re: [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an  exception Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-06-07 00:00 +0200
  [PATCH 04/10] ARC: typos fix in kernel/entry-compact.S Noam Camus <noamca@mellanox.com> - 2017-05-25 04:40 +0200
    Re: [PATCH 04/10] ARC: typos fix in kernel/entry-compact.S Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-05-25 13:10 +0200

csiph-web