[PATCH 08/14] mwifiex: ensure "disable auto DS" struct is initialized

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH 08/14] mwifiex: ensure "disable auto DS" struct is initialized
Date	2017-05-25 02:20 +0200
Message-ID	<tKOFs-Qx-15@gated-at.bofh.it> (permalink)
References	<tKOFr-Qx-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The .idle_time field *should* be unused, but technically, we're allowing
unitialized stack garbage to pass all the way through to the firmware
host command. Let's zero it out instead.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
index 42997e05d90f..43ecd621d1ef 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
@@ -654,9 +654,9 @@ int mwifiex_get_bss_info(struct mwifiex_private *priv,
  */
 int mwifiex_disable_auto_ds(struct mwifiex_private *priv)
 {
-	struct mwifiex_ds_auto_ds auto_ds;
-
-	auto_ds.auto_ds = DEEP_SLEEP_OFF;
+	struct mwifiex_ds_auto_ds auto_ds = {
+		.auto_ds = DEEP_SLEEP_OFF,
+	};
 
 	return mwifiex_send_cmd(priv, HostCmd_CMD_802_11_PS_MODE_ENH,
 				DIS_AUTO_PS, BITMAP_AUTO_DS, &auto_ds, true);
-- 
2.13.0.219.gdb65acc882-goog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 08/14] mwifiex: ensure "disable auto DS" struct is initialized Brian Norris <briannorris@chromium.org> - 2017-05-25 02:20 +0200

csiph-web