Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open"

From	"Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open"
Date	2017-05-25 01:10 +0200
Message-ID	<tKNzI-aF-3@gated-at.bofh.it> (permalink)
References	(4 earlier) <tHiVs-57h-9@gated-at.bofh.it> <tHkkz-6aZ-33@gated-at.bofh.it> <tHkDT-6ia-7@gated-at.bofh.it> <tHm2Z-7kX-17@gated-at.bofh.it> <tKzwJ-88W-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 24, 2017 at 10:08 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> Hi Rafael,
>
> On May 15 2017 or thereabouts, Rafael J. Wysocki wrote:
>> >> >> Benjamin, my understanding is that this is the case, is it correct?
>> >> >
>> >> > That is correct. This patch I reverted introduces regression for professional
>> >> > laptops that expect the LID switch to be reported accurately.
>> >>
>> >> And from a user's perspective, what does not work any more?
>> >
>> > If you boot or resume your laptop with the lid closed on a docking
>> > station while using an external monitor connected to it, both internal
>> > and external displays will light on, while only the external should.
>> >
>> > There is a design choice in gdm to only provide the greater on the
>> > internal display when lit on, so users only see a gray area on the
>> > external monitor. Also, the cursor will not show up as it's by default
>> > on the internal display too.
>> >
>> > To "fix" that, users have to open the laptop once and close it once
>> > again to sync the state of the switch with the hardware state.
>>
>> OK
>>
>> Yeah, that sucks.
>>
>> So without the Lv's patch the behavior (on the systems in question) is
>> as expected, right?
>
> Would you agree to take both these reverts without Lv's ACK? We already
> tried to explain for 2 weeks that they are valuable, but it seems we
> can't make change his mind.

One of the reverts actually is already in (as a patch from Lv) and
I'll most probably push the other one for -rc4 next week.

Thanks,
Rafael

Thread

RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-12 04:40 +0200
  Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-05-13 00:00 +0200
    Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-15 09:50 +0200
      Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-15 11:20 +0200
        Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-15 11:40 +0200
          Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-15 13:10 +0200
            Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-15 15:10 +0200
              RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-16 07:40 +0200
                RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-16 07:50 +0200
                Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-16 09:20 +0200
                RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-16 10:40 +0200
                Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-16 12:20 +0200
                RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-17 09:40 +0200
                RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Peter Hutterer <peter.hutterer@who-t.net> - 2017-05-17 14:30 +0200
                Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-17 16:20 +0200
            Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-24 10:10 +0200
              Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-25 01:10 +0200
                RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" "Zheng, Lv" <lv.zheng@intel.com> - 2017-05-25 08:20 +0200
              Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to  lid_init_state=open" Peter Hutterer <peter.hutterer@who-t.net> - 2017-05-26 09:50 +0200
                Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-05-27 21:40 +0200

csiph-web