Re: [PATCH v1 2/2] PCI: Correct PCI_STD_RESOURCE_END usage

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 2/2] PCI: Correct PCI_STD_RESOURCE_END usage
Date	2017-05-24 23:50 +0200
Message-ID	<tKMkj-7HS-35@gated-at.bofh.it> (permalink)
References	<tIWe6-6Zg-15@gated-at.bofh.it> <tIWe6-6Zg-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 19, 2017 at 02:58:55PM -0500, Bjorn Helgaas wrote:
> PCI_STD_RESOURCE_END is (confusingly) the index of the last valid BAR, not
> the *number* of BARs.  To iterate through all possible BARs, we need to
> include PCI_STD_RESOURCE_END.
> 
> Fixes: 9fe373f9997b ("PCI: Increase IBM ipr SAS Crocodile BARs to at least system page size")
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

I applied both of these to pci/misc for v4.13.

> ---
>  drivers/pci/quirks.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 085fb787aa9e..16e6cd86ad71 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -304,7 +304,7 @@ static void quirk_extend_bar_to_page(struct pci_dev *dev)
>  {
>  	int i;
>  
> -	for (i = 0; i < PCI_STD_RESOURCE_END; i++) {
> +	for (i = 0; i <= PCI_STD_RESOURCE_END; i++) {
>  		struct resource *r = &dev->resource[i];
>  
>  		if (r->flags & IORESOURCE_MEM && resource_size(r) < PAGE_SIZE) {
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 2/2] PCI: Correct PCI_STD_RESOURCE_END usage Bjorn Helgaas <bhelgaas@google.com> - 2017-05-19 22:00 +0200
  Re: [PATCH v1 2/2] PCI: Correct PCI_STD_RESOURCE_END usage Bjorn Helgaas <helgaas@kernel.org> - 2017-05-24 23:50 +0200

csiph-web