Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1649787
| From | "Malavali, Giridhar" <Giridhar.Malavali@cavium.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device |
| Date | 2017-05-24 19:20 +0200 |
| Message-ID | <tKI70-5bS-17@gated-at.bofh.it> (permalink) |
| References | <tKjrX-4z9-3@gated-at.bofh.it> <tKGHU-49Y-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 5/24/17, 8:47 AM, "Bart Van Assche" <Bart.VanAssche@sandisk.com> wrote:
>On Tue, 2017-05-23 at 16:50 +0200, Johannes Thumshirn wrote:
>> When pci_enable_device() or pci_enable_device_mem() fail in
>> qla2x00_probe_one() we bail out but do a call to
>> pci_disable_device(). This causes the dev_WARN_ON() in
>> pci_disable_device() to trigger, as the device wasn't enabled
>> previously.
>>
>> So instead of taking the 'probe_out' error path we can directly return
>> *iff* one of the pci_enable_device() calls fails.
>>
>> Additionally rename the 'probe_out' goto label's name to the more
>> descriptive 'disable_device'.
>>
>> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
>> Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data
>>structure refactoring")
>
>Hello Johannes,
>
>Please consider adding a Cc: stable tag to this patch. Since otherwise
>this
>patch looks fine to me:
>
>Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Looks good to me.
Reviewed-by: Giridhar Malavali <giridhar.malavali@cavium.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] qla2xxx: don't disable a not previously enabled PCI device Johannes Thumshirn <jthumshirn@suse.de> - 2017-05-23 17:00 +0200
Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-24 04:40 +0200
Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-05-24 17:50 +0200
Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device "Malavali, Giridhar" <Giridhar.Malavali@cavium.com> - 2017-05-24 19:20 +0200
Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-24 21:20 +0200
csiph-web