Re: [PATCH 1/1] bug: fix problem including <linux.bug.h> from linux/kernel.h

From	Ian Abbott <abbotti@mev.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] bug: fix problem including <linux.bug.h> from linux/kernel.h
Date	2017-05-24 18:10 +0200
Message-ID	<tKH1g-4vB-21@gated-at.bofh.it> (permalink)
References	<tKEwp-2RX-3@gated-at.bofh.it> <tKEwp-2RX-1@gated-at.bofh.it> <tKEG6-2V1-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24/05/17 14:37, Rasmus Villemoes wrote:
> On 24 May 2017 at 15:21, Ian Abbott <abbotti@mev.co.uk> wrote:
>> If "include/linux/kernel.h" includes <linux/bug.h>, a circular
>> dependency is introduced
>
> Then don't. Can't we just create linux/build_bug.h and have that
> contain the BUILD_BUG related macros - they're really completely
> unrelated to all the asm-cruft bug.h needs to know about. build_bug.h
> can then include compiler.h and not much else to figure out how it may
> implement its macros. Then kernel.h can include build_bug.h, and we
> don't force each and every translation unit to include bug.h and
> everything that then pulls in. We just got rid of a lot of header
> bloat, let's try to keep it that way.

Thanks, I'll take a look at that.  In the meantime, I noticed the title 
line of this patch contains a nasty typo, so I'll send a v2 patch to fix 
that.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Thread

[PATCH 1/1] bug: fix problem including <linux.bug.h> from linux/kernel.h Ian Abbott <abbotti@mev.co.uk> - 2017-05-24 15:30 +0200
  Re: [PATCH 1/1] bug: fix problem including <linux.bug.h> from linux/kernel.h Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2017-05-24 15:40 +0200
    Re: [PATCH 1/1] bug: fix problem including <linux.bug.h> from  linux/kernel.h Ian Abbott <abbotti@mev.co.uk> - 2017-05-24 18:10 +0200
  [PATCH v2] bug: fix problem including <linux/bug.h> from linux/kernel.h Ian Abbott <abbotti@mev.co.uk> - 2017-05-24 18:10 +0200
    Re: [PATCH v2] bug: fix problem including <linux/bug.h> from  linux/kernel.h Ian Abbott <abbotti@mev.co.uk> - 2017-05-25 01:20 +0200

csiph-web