Re: [PATCH] MIPS: Octeon: Delete an error message for a failed memory allocation in octeon_irq_init_gpio()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MIPS: Octeon: Delete an error message for a failed memory allocation in octeon_irq_init_gpio()
Date	2017-05-24 18:10 +0200
Message-ID	<tKH1f-4vB-13@gated-at.bofh.it> (permalink)
References	<tKmzw-6Qv-17@gated-at.bofh.it> <tKncd-77q-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> +++ b/arch/mips/cavium-octeon/octeon-irq.c
>> @@ -1615,7 +1615,6 @@ static int __init octeon_irq_init_gpio(
>>  		irq_domain_add_linear(
>>  			gpio_node, 16, &octeon_irq_domain_gpio_ops, gpiod);
>>  	} else {
>> -		pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
>>  		return -ENOMEM;
>>  	}
> 
> You really should reverse the test here and
> unindent the first block.

Thanks for your improved source code transformation.

I am curious if I will stumble on a similar change possibility once more
for remaining update candidates in other software areas.

Regards,
Markus

Thread

[PATCH] MIPS: Octeon: Delete an error message for a failed memory  allocation in octeon_irq_init_gpio() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-23 20:20 +0200
  Re: [PATCH] MIPS: Octeon: Delete an error message for a failed  memory allocation in octeon_irq_init_gpio() Joe Perches <joe@perches.com> - 2017-05-23 21:00 +0200
    Re: [PATCH] MIPS: Octeon: Delete an error message for a failed memory  allocation in octeon_irq_init_gpio() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-24 18:10 +0200
      Re: [PATCH] MIPS: Octeon: Delete an error message for a failed  memory allocation in octeon_irq_init_gpio() Joe Perches <joe@perches.com> - 2017-05-24 21:50 +0200
        Re: [PATCH] MIPS: Octeon: Delete an error message for a failed memory  allocation in octeon_irq_init_gpio() Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-29 21:40 +0200

csiph-web