RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs

From	"Deucher, Alexander" <Alexander.Deucher@amd.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs
Date	2017-05-24 15:10 +0200
Message-ID	<tKEd3-2Lr-11@gated-at.bofh.it> (permalink)
References	<ttDdo-8mD-27@gated-at.bofh.it> <ttFfc-1ms-31@gated-at.bofh.it> <tDmbf-28q-7@gated-at.bofh.it> <tKo8i-7OL-7@gated-at.bofh.it> <tKA9s-8rl-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Joerg Roedel [mailto:jroedel@suse.de]
> Sent: Wednesday, May 24, 2017 4:45 AM
> To: Deucher, Alexander
> Cc: 'David Woodhouse'; 'Joerg Roedel'; Bjorn Helgaas; linux-
> pci@vger.kernel.org; linux-kernel@vger.kernel.org; Daniel Drake; Samuel
> Sieb
> Subject: Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs
> 
> Hi Alexander,
> 
> On Tue, May 23, 2017 at 07:54:12PM +0000, Deucher, Alexander wrote:
> > I finally got an answer from the hw team and we validated ATS on
> > stoney as well so in theory this patch shouldn’t actually be needed.
> > I think we may actually be papering over some other issue.  The
> > following patch seems to also fix this issue (and other issues):
> > https://www.spinics.net/lists/stable/msg172631.html
> 
> Yeah, but it still looks to me like that the hardware got into some
> weird state with the storm of ATS invalidations sent to it.
> 
> The Completion-Wait loop timeouts seen in the original bug report
> indicate that the IOMMU is waiting for a response that never comes. And
> this is probably the ATS flush completion response from the GPU, as
> disabling ATS on the GPU makes the issue disappear.

Yeah, it's weird.  My ack on the patch still stands.  Just adding some additional data.

Alex

Thread

RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-05-23 22:00 +0200
  Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Joerg Roedel <jroedel@suse.de> - 2017-05-24 10:50 +0200
    Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs David Woodhouse <dwmw2@infradead.org> - 2017-05-24 12:50 +0200
    RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-05-24 15:10 +0200
      Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Samuel Sieb <samuel@sieb.net> - 2017-05-26 09:00 +0200
    RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-05-26 14:00 +0200
      Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs David Woodhouse <dwmw2@infradead.org> - 2017-05-26 15:00 +0200
        RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-05-26 18:10 +0200

csiph-web