Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1649581

Re: bitmap API consistency

Show all headers | View raw

On 24 May 2017 at 14:11, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Hi!
>
> Surprisingly discovered today that bitmap API is not consistent in some
> cases (at least one I found recently).
>
> bitmap_fill() sets area of bits in a bitmap.
> bitmap_zero() clears them.
>
> However, if _fill() does something sane, _zero() clears _all_ bits up to
> word size (long).
>
> I think it should be fixed to be consistent with _fill() variant.

What do you want it to do? It always acts on whole words, so the last
word must be set to something. One might as well say that _zero and
_fill are consistent in that they both set the bits beyond nbits in
the last word to 0.

If anything, I'd change bitmap_fill to do a memset(0xff) of the entire
region. There used to be bugs where some of the bitmap_* functions
didn't actually ignore the trailing bits, making it somewhat important
that they were always 0, but I think they're fixed now.

Note that if one wants a guarantee that the trailing bits are not
touched at all, the APIs to use are bitmap_{set, clear}(dst, 0,
count). bitmap_{zero,fill} assumes that nbits is the total size of the
bitmap (i.e. that the user will never care about bits beyond nbits).
Maybe a few comments could be added somewhere.

Rasmus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

bitmap API consistency Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-24 14:20 +0200
  Re: bitmap API consistency Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2017-05-24 14:40 +0200
    Re: bitmap API consistency Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-24 14:50 +0200

csiph-web