Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1649537

Re: [PATCH v2 09/12] gpio: acpi: Split out acpi_gpio_get_irq_resource() helper

Show all headers | View raw

On Tue, May 23, 2017 at 08:03:24PM +0300, Andy Shevchenko wrote:
> The helper does retrieve pointer to struct acpi_resource_gpio from
> struct acpi_resource if it represents GpioInt() resource.
> 
> It will be used by PNP code later on.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpiolib-acpi.c | 23 ++++++++++++++++++-----
>  include/linux/acpi.h        |  7 +++++++
>  2 files changed, 25 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index e431222edc2b..6bea176b066c 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -165,6 +165,23 @@ static void acpi_gpio_chip_dh(acpi_handle handle, void *data)
>  	/* The address of this function is used as a key. */
>  }

Since this is exported, it might be good idea to provide kernel-doc
here.

Anyway,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

> +bool acpi_gpio_get_irq_resource(struct acpi_resource *ares,
> +				struct acpi_resource_gpio **agpio)
> +{
> +	struct acpi_resource_gpio *gpio;
> +
> +	if (ares->type != ACPI_RESOURCE_TYPE_GPIO)
> +		return false;
> +
> +	gpio = &ares->data.gpio;
> +	if (gpio->connection_type != ACPI_RESOURCE_GPIO_TYPE_INT)
> +		return false;
> +
> +	*agpio = gpio;
> +	return true;
> +}
> +EXPORT_SYMBOL_GPL(acpi_gpio_get_irq_resource);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/12] gpio: acpi: Make it working Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-23 19:10 +0200
  [PATCH v2 02/12] gpio: acpi: Align acpi_find_gpio() with DT version Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-23 19:10 +0200
    Re: [PATCH v2 02/12] gpio: acpi: Align acpi_find_gpio() with DT version Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 11:20 +0200
  [PATCH v2 11/12] PNP / ACPI: join strings back for better maintenance Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-23 19:10 +0200
    Re: [PATCH v2 11/12] PNP / ACPI: join strings back for better  maintenance Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-24 14:10 +0200
    Re: [PATCH v2 11/12] PNP / ACPI: join strings back for better maintenance Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 11:30 +0200
  [PATCH v2 09/12] gpio: acpi: Split out acpi_gpio_get_irq_resource() helper Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-23 19:10 +0200
    Re: [PATCH v2 09/12] gpio: acpi: Split out  acpi_gpio_get_irq_resource() helper Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-24 14:00 +0200
    Re: [PATCH v2 09/12] gpio: acpi: Split out acpi_gpio_get_irq_resource()  helper Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 11:30 +0200
  [PATCH v2 08/12] gpio: acpi: Override GPIO initialization flags Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-23 19:10 +0200
  [PATCH v2 12/12] PNP / ACPI: remove FSF address Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-23 19:10 +0200
    Re: [PATCH v2 12/12] PNP / ACPI: remove FSF address Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-24 14:10 +0200
    Re: [PATCH v2 12/12] PNP / ACPI: remove FSF address Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 11:30 +0200
  [PATCH v2 01/12] gpiolib: Export gpiod_configure_flags() to internal users Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-23 19:10 +0200
    Re: [PATCH v2 01/12] gpiolib: Export gpiod_configure_flags() to  internal users Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 11:20 +0200
  Re: [PATCH v2 00/12] gpio: acpi: Make it working Linus Walleij <linus.walleij@linaro.org> - 2017-05-29 11:40 +0200
    Re: [PATCH v2 00/12] gpio: acpi: Make it working Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-29 15:20 +0200

csiph-web