Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1649468

Re: [PATCH 1/2] nvme: fix multiple ctrl removal scheduling

Show all headers | View raw

On Wed, May 24, 2017 at 11:37:55AM +0200, Christoph Hellwig wrote:
> On Wed, May 24, 2017 at 01:15:47AM +0300, Rakesh Pandit wrote:
> > Commit c5f6ce97c1210 tries to address multiple resets but fails as
> > work_busy doesn't involve any synchronization and can fail.  This is
> > reproducible easily as can be seen by WARNING below which is triggered
> > with line:
> > 
> > WARN_ON(dev->ctrl.state == NVME_CTRL_RESETTING)
> > 
> > Allowing multiple resets can result in multiple controller removal as
> > well if different conditions inside nvme_reset_work fail and which
> > might deadlock on device_release_driver.
> > 
> > This patch addresses the problem by using state of controller to
> > decide whether reset should be queued or not as state change is
> > synchronizated using controller spinlock.
> 
> But we don't hold the lock over the check and the decision.  I suspect

Thanks, right.

> what we need to do is to actually change to the resetting state
> before queueing up the reset work.  Can you give that a spin?

Sure, will post it in next version.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] nvme: fix multiple ctrl removal scheduling Rakesh Pandit <rakesh@tuxera.com> - 2017-05-24 00:20 +0200
  Re: [PATCH 1/2] nvme: fix multiple ctrl removal scheduling Christoph Hellwig <hch@lst.de> - 2017-05-24 11:40 +0200
    Re: [PATCH 1/2] nvme: fix multiple ctrl removal scheduling Rakesh Pandit <rakesh@tuxera.com> - 2017-05-24 13:10 +0200

csiph-web