Re: [PATCH v2] mfd: wm831x: add null check before pointer dereference

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mfd: wm831x: add null check before pointer dereference
Date	2017-05-24 13:00 +0200
Message-ID	<tKCbg-1hF-23@gated-at.bofh.it> (permalink)
References	<tKAj8-8uU-3@gated-at.bofh.it> <tKACt-pV-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 24 May 2017, Gustavo A. R. Silva wrote:

> Add NULL check before dereferencing pointer of_id in order to avoid
> a potential NULL pointer dereference.
> 
> Addresses-Coverity-ID: 1408830
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
>  Update error log and return value.
> 
>  drivers/mfd/wm831x-spi.c | 4 ++++
>  1 file changed, 4 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c
> index c332e28..018ce65 100644
> --- a/drivers/mfd/wm831x-spi.c
> +++ b/drivers/mfd/wm831x-spi.c
> @@ -34,6 +34,10 @@ static int wm831x_spi_probe(struct spi_device *spi)
>  
>  	if (spi->dev.of_node) {
>  		of_id = of_match_device(wm831x_of_match, &spi->dev);
> +		if (!of_id) {
> +			dev_err(&spi->dev, "Failed to match device\n");
> +			return -ENODEV;
> +		}
>  		type = (enum wm831x_parent)of_id->data;
>  	} else {
>  		type = (enum wm831x_parent)id->driver_data;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: add null check before pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-24 10:30 +0200
  Re: [PATCH] mfd: add null check before pointer dereference Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-05-24 10:50 +0200
  Re: [PATCH] mfd: add null check before pointer dereference Lee Jones <lee.jones@linaro.org> - 2017-05-24 10:50 +0200
    Re: [PATCH] mfd: add null check before pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-24 11:00 +0200
      [PATCH v2] mfd: wm831x: add null check before pointer dereference "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-24 11:20 +0200
        Re: [PATCH v2] mfd: wm831x: add null check before pointer dereference Lee Jones <lee.jones@linaro.org> - 2017-05-24 13:00 +0200

csiph-web