Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647484

Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush code

From Nadav Amit <nadav.amit@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush code
Date 2017-05-23 01:30 +0200
Message-ID <tK4VX-3CT-17@gated-at.bofh.it> (permalink)
References <tK49z-385-3@gated-at.bofh.it> <tK49z-385-3@gated-at.bofh.it> <tK49z-385-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> 
> 	/* Balance as user space task's flush, a bit conservative */
> 	if (end == TLB_FLUSH_ALL ||
> -	    (end - start) > tlb_single_page_flush_ceiling * PAGE_SIZE) {
> +	    (end - start) > tlb_single_page_flush_ceiling >> PAGE_SHIFT) {

Shouldn’t it be << ?

Nadav

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush code Andy Lutomirski <luto@kernel.org> - 2017-05-23 00:40 +0200
  Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs  PAGE_SIZE in tlb flush code Nadav Amit <nadav.amit@gmail.com> - 2017-05-23 01:30 +0200
    Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs  PAGE_SIZE in tlb flush code Andy Lutomirski <luto@kernel.org> - 2017-05-23 01:50 +0200

csiph-web