Re: [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE / RAW events

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE / RAW events
Date	2017-05-23 01:30 +0200
Message-ID	<tK4VX-3CT-11@gated-at.bofh.it> (permalink)
References	<tK4jf-3bn-3@gated-at.bofh.it> <tK4jf-3bn-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Alexei Starovoitov <ast@fb.com>
Date: Mon, 22 May 2017 15:48:40 -0700

> @@ -31,7 +31,7 @@ static unsigned long long (*bpf_get_current_uid_gid)(void) =
>  	(void *) BPF_FUNC_get_current_uid_gid;
>  static int (*bpf_get_current_comm)(void *buf, int buf_size) =
>  	(void *) BPF_FUNC_get_current_comm;
> -static int (*bpf_perf_event_read)(void *map, int index) =
> +static u64 (*bpf_perf_event_read)(void *map, u64 flags) =
>  	(void *) BPF_FUNC_perf_event_read;

If the second argument really is "u64 flags", then please update
the comments in tools/include/uapi/linux/bpf.h as well.

Thank you.

Thread

[PATCH net-next 0/2] perf, bpf: add support for HW_CACHE and RAW events Alexei Starovoitov <ast@fb.com> - 2017-05-23 00:50 +0200
  [PATCH net-next 1/2] perf, bpf: add support for HW_CACHE and RAW events Alexei Starovoitov <ast@fb.com> - 2017-05-23 00:50 +0200
    Re: [PATCH net-next 1/2] perf, bpf: add support for HW_CACHE and RAW  events Peter Zijlstra <peterz@infradead.org> - 2017-05-23 09:50 +0200
      Re: [PATCH net-next 1/2] perf, bpf: add support for HW_CACHE and RAW  events Peter Zijlstra <peterz@infradead.org> - 2017-05-23 18:40 +0200
  [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE / RAW events Alexei Starovoitov <ast@fb.com> - 2017-05-23 00:50 +0200
    Re: [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE /  RAW events David Miller <davem@davemloft.net> - 2017-05-23 01:30 +0200
      Re: [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE /  RAW events David Miller <davem@davemloft.net> - 2017-05-23 01:50 +0200

csiph-web