Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647421

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

From Andrew Morton <akpm@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems
Date 2017-05-22 23:50 +0200
Message-ID <tK3nb-2zS-9@gated-at.bofh.it> (permalink)
References <tIXjP-7UF-11@gated-at.bofh.it> <tIXjQ-7UF-37@gated-at.bofh.it> <tK2hr-1Tl-7@gated-at.bofh.it> <tK2AO-1ZI-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 22 May 2017 13:56:21 -0700 Matthias Kaehlcke <mka@chromium.org> wrote:

> El Mon, May 22, 2017 at 01:39:26PM -0700 David Rientjes ha dit:
> 
> > On Fri, 19 May 2017, Matthias Kaehlcke wrote:
> > 
> > > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef
> > > block fixes the following warning when building with clang:
> > > 
> > > mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook'
> > >     [-Werror,-Wunused-function]
> > > 
> > 
> > Is clang not inlining kmalloc_large_node_hook() for some reason?  I don't 
> > think this should ever warn on gcc.
> 
> clang warns about unused static inline functions outside of header
> files, in difference to gcc.

I wish it wouldn't.  These patches just add clutter.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems Matthias Kaehlcke <mka@chromium.org> - 2017-05-19 23:10 +0200
  Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems David Rientjes <rientjes@google.com> - 2017-05-22 22:40 +0200
    Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems Matthias Kaehlcke <mka@chromium.org> - 2017-05-22 23:00 +0200
      Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems Andrew Morton <akpm@linux-foundation.org> - 2017-05-22 23:50 +0200
        Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems David Rientjes <rientjes@google.com> - 2017-05-23 03:40 +0200
          Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems Matthias Kaehlcke <mka@chromium.org> - 2017-05-23 19:00 +0200
            Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems Doug Anderson <dianders@chromium.org> - 2017-05-23 19:20 +0200
            Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems David Rientjes <rientjes@google.com> - 2017-05-24 22:40 +0200
              Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for  NUMA systems Matthias Kaehlcke <mka@chromium.org> - 2017-05-25 00:20 +0200

csiph-web