Re: [PATCH net-next 16/20] net: dsa: move notifier info to private header

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 16/20] net: dsa: move notifier info to private header
Date	2017-05-22 21:40 +0200
Message-ID	<tK1lo-1kI-21@gated-at.bofh.it> (permalink)
References	<tIXjP-7UF-3@gated-at.bofh.it> <tIXjR-7UF-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/19/2017 02:00 PM, Vivien Didelot wrote:
> The DSA notifier events and info structure definitions are not meant for
> DSA drivers and users, but only used internally by the DSA core files.
> 
> Move them from the public net/dsa.h file to the private dsa_priv.h file.
> 
> Also use this opportunity to turn the events into an anonymous enum,
> because we don't care about the values, and this will prevent future
> conflicts when adding (and sorting) new events.

LGTM

> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 16/20] net: dsa: move notifier info to private header Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-19 23:10 +0200
  Re: [PATCH net-next 16/20] net: dsa: move notifier info to private  header Florian Fainelli <f.fainelli@gmail.com> - 2017-05-22 21:40 +0200

csiph-web