Re: [PATCH net-next 08/20] net: dsa: change scope of ageing time setter

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 08/20] net: dsa: change scope of ageing time setter
Date	2017-05-22 21:30 +0200
Message-ID	<tK1bJ-1hH-25@gated-at.bofh.it> (permalink)
References	<tIXjP-7UF-3@gated-at.bofh.it> <tIXjP-7UF-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/19/2017 02:00 PM, Vivien Didelot wrote:
> Change the scope of the switchdev bridge ageing time attribute setter
> from the DSA slave device to the generic DSA port, so that the future
> port-wide API can also be used for other port types, such as CPU and DSA
> links.
> 
> Also ds->ports is now a contiguous array of dsa_port structures, thus
> their addresses cannot be NULL. Remove the useless check in
> dsa_fastest_ageing_time.

And you are also passing just the ageing time value, and not longer the
full attribute, which is a nice simplification.

> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 08/20] net: dsa: change scope of ageing time setter Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-19 23:10 +0200
  Re: [PATCH net-next 08/20] net: dsa: change scope of ageing time  setter Florian Fainelli <f.fainelli@gmail.com> - 2017-05-22 21:30 +0200

csiph-web