Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647282

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

Show all headers | View raw

Hi Rui/Valentin,

Do you have any comments on this patch ? If you agree with this patch, 
Can you please Ack it ?


On 05/22/2017 03:17 AM, Lee Jones wrote:
> On Fri, 14 Apr 2017, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> PMIC mfd driver only exports first level irq for thermal device.
>> But currently we are reading the irqs from the second level irq
>> chip, So this patch fixes this issue by adding support to use
>> first level PMIC thermal irq.
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> This still needs a Maintainer Ack.
>
>> ---
>>   drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Changes since v1:
>>   * None
>>
>> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c b/drivers/thermal/intel_bxt_pmic_thermal.c
>> index 0f19a39..ef6b322 100644
>> --- a/drivers/thermal/intel_bxt_pmic_thermal.c
>> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
>> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev)
>>   	}
>>   
>>   	regmap = pmic->regmap;
>> -	regmap_irq_chip = pmic->irq_chip_data_level2;
>> +	regmap_irq_chip = pmic->irq_chip_data;
>>   
>>   	pmic_irq_count = 0;
>>   	while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {

-- 
Sathyanarayanan Kuppuswamy
Linux kernel developer

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level  PMIC thermal irq Lee Jones <lee.jones@linaro.org> - 2017-05-22 12:20 +0200
  Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level  PMIC thermal irq sathyanarayanan kuppuswamy          <sathyanarayanan.kuppuswamy@linux.intel.com> - 2017-05-22 21:20 +0200

csiph-web