Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1647269
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Joe Perches <joe@perches.com> |
| Newsgroups | linux.kernel |
| Subject | Re: checkpatch.pl false positive |
| Date | Mon, 22 May 2017 21:00:02 +0200 |
| Message-ID | <tK0IG-R8-17@gated-at.bofh.it> (permalink) |
| References | <tK0IG-R8-19@gated-at.bofh.it> |
| X-Session-Marker | 6A6F6540706572636865732E636F6D |
| X-Spam-Summary | 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1588:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2687:2693:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6226:10004:10400:10848:11232:11658:11783:11914:12043:12296:12740:12895:13069:13071:13141:13230:13311:13357:13439:13894:14180:14181:14659:21060:21080:21451:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none |
| X-He-Tag | year31_126e3429f9332 |
| X-Filterd-Recvd-Size | 1870 |
| Content-Type | text/plain; charset="ISO-8859-1" |
| X-Mailer | Evolution 3.22.6-1ubuntu1 |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 8bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 34 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | LKML <linux-kernel@vger.kernel.org> |
| X-Original-Date | Mon, 22 May 2017 11:52:05 -0700 |
| X-Original-Message-ID | <1495479125.2093.39.camel@perches.com> |
| X-Original-References | <DB6PR0901MB1173A77EA985D67344E42029F5E50@DB6PR0901MB1173.eurprd09.prod.outlook.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1647269 |
Show key headers only | View raw
On Fri, 2017-05-19 at 09:57 +0000, Antonio Niño Díaz wrote: > Hello, Hi. > I think I've hit a corner case in checkpatch.pl. It is easy to reproduce, just create a patch with a new line such as: > > #define MY_HEADER <header.h> [ checkpatch outputs ] > config.h:9: ERROR: spaces required around that '<' (ctx:WxV) > +#define MY_HEADER <header.h> ^ > config.h:9: ERROR: spaces required around that '>' (ctx:VxE) > +#define MY_HEADER <header.h> Yeah, checkpatch doesn't know about the #define before the other things it tests. > Will you add this as an exception, or it is not an issue for > you as the Linux kernel doesn't really use this weird system? Probably not as it's not a kernel usage and I can't think of a decent way to avoid it. maybe some substitution like $rawline =~ s/^(\s*#\s*define\s+\w+\s+)<([^>]+>)/\1"\2"/ could help, but it's pretty obscure and probably not used in many other projects. Maybe you could add and keep it local to your use.
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: checkpatch.pl false positive Joe Perches <joe@perches.com> - 2017-05-22 21:00 +0200
csiph-web