Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1646336

Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102

From Jonathan Cameron <jic23@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102
Date 2017-05-21 14:20 +0200
Message-ID <tJy01-7Fz-3@gated-at.bofh.it> (permalink)
References <tI93J-4Nh-27@gated-at.bofh.it> <tJwAW-6Es-19@gated-at.bofh.it> <tJxGF-7jx-3@gated-at.bofh.it> <tJy01-7Fz-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 21/05/17 13:17, Jonathan Cameron wrote:
> On 21/05/17 12:59, Jan Kiszka wrote:
>> On 2017-05-21 12:47, Jonathan Cameron wrote:
>>> On 17/05/17 16:28, Jan Kiszka wrote:
>>>> This is an upstream port of an IIO driver for the TI ADC108S102 and
>>>> ADC128S102. The former can be found on the Intel Galileo Gen2 and the
>>>> Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is
>>>> included.
>>>>
>>>> Due to the lack of regulators under ACPI, we hard-code the voltage
>>>> provided to the VA pin of the ADC to 5 V, the value used on Galileo and
>>>> IOT2000. For DT usage, the regulator "vref-supply" provides this
>>>> information. Note that DT usage has not been tested.
>>>>
>>>> Original author: Bogdan Pricop <bogdan.pricop@emutex.com>
>>>> Ported from Intel Galileo Gen2 BSP to Intel Yocto kernel:
>>>> Todor Minchev <todor@minchev.co.uk>.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> Still an issue wrt to it being obviously correct in the ordering in probe
>>> and remove.
>>>
>>> As a reviewer I want to be able to run through each step in probe and
>>> compare with remove to ensure they occur in the opposite order and
>>> reverse all the steps in probe.  Where ever it deviates from that I have
>>> to think about it and we all know the last thing a reviewer with a big
>>> backlog of patches wants to do is to think hard ;)
>>>
>>> Anyhow, I've fixed up and applied to the togreg branch of iio.git and
>>> pushed out as testing for the autobuilders to play with it.
>>>
>>> Please check I haven't made a mess of it.
>>
>> Forgot to push? Not finding it in togreg, which is 5 days old.
>>
> As it says, pushed out as testing...  Togreg is non rebasing so only
> gets pushed out publicly once all the trivial stuff the autobuilders
> find has been sorted.
> 
> Depending on how busy I am it can be a few days before I get a chance
> to push out togreg, whereas testing goes every few patches when I'm
> merging stuff.
Mind you I hadn't pushed that for half an hour or so hence that might
have been out of date too ;)

Jonathan
> 
> Thanks,
> 
> Jonathan
>> Jan
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-17 17:30 +0200
  Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 13:10 +0200
    Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-18 14:40 +0200
      Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 14:50 +0200
  Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-21 12:50 +0200
    Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-21 14:00 +0200
      Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-21 14:20 +0200
        Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-21 14:20 +0200
          Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-21 14:50 +0200
            Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-21 16:10 +0200
              Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-21 16:20 +0200
                Re: [PATCH v6] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 08:00 +0200

csiph-web