[PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare()
Date	2017-05-21 10:30 +0200
Message-ID	<tJupr-5nU-5@gated-at.bofh.it> (permalink)
References	<tJupr-5nU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 21 May 2017 09:29:25 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 mm/zswap.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index 3f0a9a1daef4..ed7312291df9 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -374,7 +374,6 @@ static int zswap_dstmem_prepare(unsigned int cpu)
-	if (!dst) {
-		pr_err("can't allocate compressor buffer\n");
+	if (!dst)
 		return -ENOMEM;
-	}
+
 	per_cpu(zswap_dstmem, cpu) = dst;
 	return 0;
 }
-- 
2.13.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] zswap: Delete an error message for a failed memory  allocation in zswap_dstmem_prepare() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-21 10:30 +0200
  Re: [PATCH 3/3] zswap: Delete an error message for a failed memory  allocation in zswap_dstmem_prepare() Wolfram Sang <wsa@the-dreams.de> - 2017-05-21 10:50 +0200
    Re: zswap: Delete an error message for a failed memory allocation in  zswap_dstmem_prepare() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-21 11:50 +0200
      Re: zswap: Delete an error message for a failed memory allocation in  zswap_dstmem_prepare() Wolfram Sang <wsa@the-dreams.de> - 2017-05-21 12:00 +0200
        Re: Using best practices for big software change possibilities SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-21 12:20 +0200
          Re: Using best practices for big software change possibilities Wolfram Sang <wsa@the-dreams.de> - 2017-05-21 12:30 +0200
            Re: Using best practices for big software change possibilities SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-21 12:50 +0200

csiph-web